Skip to content

[DRAFT] Gh 2051 srun fixes #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

[DRAFT] Gh 2051 srun fixes #2074

wants to merge 22 commits into from

Conversation

@dbeltrankyl
Copy link
Collaborator

@dbeltrankyl dbeltrankyl commented Jan 22, 2025 •
edited
Loading

Related to #2051 and https://earth.bsc.es/gitlab/digital-twins/de_340-2/workflow/-/issues/184

  • Discarded Group_by for now
  • Contains fixes to building process for srun wrappers
  • Contains an implementation for srun using horizontal and horizontal-vertical. ( just changed the methods from python2 to bash)
  • [WIP] fixing vertical-horizontal that is the one that comes from 3.15.X

@dbeltrankyl dbeltrankyl self-assigned this Jan 22, 2025
@dbeltrankyl dbeltrankyl added this to the 4.1.13 milestone Jan 22, 2025
kinow
kinow reviewed Jan 22, 2025
View reviewed changes
@dbeltrankyl
Copy link
Collaborator Author

dbeltrankyl commented Jan 22, 2025 •
edited
Loading

Hello @kinow

Don't worry (yet) about this one; it is still a draft. I'm not able yet to run it. It doesn't work even with 3.15.20 due to the change to mn4 -> mn5... it complains about the jq command and the masks. I also had an issue with an infinite loop...

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.85714% with 99 lines in your changes missing coverage. Please review.

Project coverage is 49.95%. Comparing base (b95b91f) to head (8f18103).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
autosubmit/platforms/wrappers/wrapper_builder.py 42.85% 51 Missing and 1 partial ⚠️
autosubmit/platforms/wrappers/wrapper_factory.py 27.58% 16 Missing and 5 partials ⚠️
autosubmit/job/job_packages.py 74.66% 15 Missing and 4 partials ⚠️
autosubmit/platforms/pjmplatform.py 25.00% 3 Missing ⚠️
autosubmit/autosubmit.py 0.00% 1 Missing ⚠️
autosubmit/job/job_packager.py 80.00% 0 Missing and 1 partial ⚠️
autosubmit/platforms/headers/slurm_header.py 0.00% 0 Missing and 1 partial ⚠️
autosubmit/platforms/slurmplatform.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
+ Coverage   49.80%   49.95%   +0.14%     
==========================================
  Files          72       72              
  Lines       17569    17599      +30     
  Branches     3418     3429      +11     
==========================================
+ Hits         8751     8791      +40     
+ Misses       8007     7991      -16     
- Partials      811      817       +6
Flag Coverage Δ
fast-tests 49.95% <52.85%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dbeltrankyl
dbeltrankyl commented Jan 29, 2025
View reviewed changes
@dbeltrankyl dbeltrankyl mentioned this pull request Jan 29, 2025
Open
@dbeltrankyl
Vertical added, srun renamed to uppercase
7fb110f 
Vertical-horizontal not working yet
@dbeltrankyl dbeltrankyl marked this pull request as draft January 30, 2025 09:23
@dbeltrankyl
Copy link
Collaborator Author

dbeltrankyl commented Apr 17, 2025

Hm, I totally forgot about srun wrappers

@franra9 are the srun wrappers still needed? If so with what urgency?

@dbeltrankyl dbeltrankyl modified the milestones: 4.1.13, 4.1.15 Apr 17, 2025
@dbeltrankyl
Copy link
Collaborator Author

dbeltrankyl commented Apr 17, 2025

Set to 4.1.15, but depending on the urgency it will be moved to 4.2 as the #2211 is a critical issue for the june deadline

@dbeltrankyl dbeltrankyl modified the milestones: 4.1.15, 4.2.1 May 15, 2025
@dbeltrankyl dbeltrankyl mentioned this pull request May 29, 2025
Open
@dbeltrankyl
Copy link
Collaborator Author

dbeltrankyl commented Oct 31, 2025

I don't remember this one (8 months), but it will probably be looked from scratch after 4.2.

Keeping the PR open but stopped in case there is something worth to keep

@dbeltrankyl dbeltrankyl added the stopped Use this label to report that one development or discussion is stopped or postponned label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kinow kinow kinow left review comments

Assignees

@dbeltrankyl dbeltrankyl

Labels

stopped Use this label to report that one development or discussion is stopped or postponned

Projects

None yet

Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@dbeltrankyl @codecov-commenter @kinow